requirements.txt: Move instructlab to requirements-dev.txt #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still a dependency, but it's causing some problems in `instructlab` repo CI. A released version of instructlab gets installed first because of this entry, then it has to be uninstalled before the development version can be installed. The currently released version of `instructlab` still has schema embedded. The next release (and current `main`) uses the `instructlab-schema` package. Moving from one to the other in tox is breaking the schema package. By moving it, it will still be installed for local repo testing purposes. This should solve the CI failures seen here: instructlab/instructlab#1244 Signed-off-by: Russell Bryant <[email protected]>
russellb
changed the title
|
This is a trivial change that's blocking the CLI change to use the library, so I'm just going to merge it. Once we get to a working initial state, I won't do merges like this. |
jwm4
pushed a commit
to jwm4/sdg
that referenced
this pull request
Dec 13, 2024
github: Document the option of using Mergify for merge automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
70335a1 requirements.txt: instructlab to requirements-dev.txt
commit 70335a1
Author: Russell Bryant [email protected]
Date: Tue Jun 18 21:26:12 2024 -0400